Shattered Kingdoms
https://shatteredkingdoms.org/forums/

Please review the dehoarding code. Stealing gear it shouldnt
https://shatteredkingdoms.org/forums/viewtopic.php?f=26&t=26330		 Page 1 of 1
Author:  Nokuro [ Mon Feb 20, 2017 12:34 pm ]
Post subject:  Please review the dehoarding code. Stealing gear it shouldnt
My main logged out last night with 4 weapons, one bracelet, and one ring in inventory.

When I logged in this morning, TWO of his primary weapons had been removed by log-out thieves.

Can we please review this code? I'll include a brief log of what I logged out with, and what was stolen.

Quote:
examine flowing
A pile of adamantite mesh lies on the ground.
A flowing cloak of chain link is made of adamantite and size giant.
When you look inside, you see:
A flowing cloak of chain link contains:
an ornate mithril chalice decorated with skulls filled with water
(Glowing) (Humming) The Staff of the Four Winds (brand new)
a mithril ring adorned with rubies (superb)
a short silver wand
a dark polished wand
( 2) a bowl of rabbit stew
an acid stained diamond bandalore (brand new)
(Humming) a spiked bracelet etched with golden runes (brand new)
25 platinum coins
354 gold coins
119 silver coins
77 copper coins
the Soulswap (brand new)
a golden horn engraved with a dragon (brand new)
( 2) a sturdy, blown glass vial of heal
an engraven silver-gilt eye washer
( 5) a cloudy bottle
( 6) a swirly flask
( 9) a stone pill
an obsidian key (brand new)
(Glowing) a glowing potion, frothing at the rim
a fragile, blown glass vial of word of recall
a sharp mithril-tipped shovel
( 2) a severed butterfly wing
( 2) a thick greenish-brown seed pod
( 3) a vial of embalming sealant fluid



Quote:
You are carrying:
7 copper coins
5 gold coins
(Glowing) (Humming) a broad-bladed bill (brand new)
(Humming) a red-veined adamantine ajatang (brand new)



These two items were de-hoarded overnight:
Quote:
(Glowing) (Humming) The Staff of the Four Winds (brand new)
an acid stained diamond bandalore (brand new)
Author:  TacoRobot [ Mon Feb 20, 2017 12:54 pm ]
Post subject:  Re: Please review the dehoarding code. Stealing gear it shou
I could be mistaken, but I think 6 items is actually the point where you get robbed.

I swear I thought 6 was the 'safe limit' at one point, but it /appears/ to be 5 now.

I could be wrong on this, I haven't done extensive testing.

Also, as for your snippet, I'm pretty sure Soulswap is actually a necklace. So that's counting towards your limit, which would put you at 7.
Author:  Mogor [ Mon Feb 20, 2017 6:17 pm ]
Post subject:  Re: Please review the dehoarding code. Stealing gear it shou
Working as intended.

You had six items in your container, since you should have included Soulswap as part of the item count, and you are carrying two weapons in your inventory. That is a total of eight items, so two items were stolen.

If the item is not equipped and/or wielded, it counts towards your limit of six.
Author:  Gazpacho [ Mon Feb 20, 2017 8:34 pm ]
Post subject:  Re: Please review the dehoarding code. Stealing gear it shou
Code:
a golden horn engraved with a dragon (brand new)


This item too, potentially. The horn, coupled with Soulswap would put you two items over the limit.
Author:  Nokuro [ Tue Feb 21, 2017 4:46 pm ]
Post subject:  Re: Please review the dehoarding code. Stealing gear it shou
Thanks for the replies, all :)

clearly I need to doublecheck which items count towards the limit!
Author:  Dubzilla [ Thu Feb 23, 2017 2:58 pm ]
Post subject:  Re: Please review the dehoarding code. Stealing gear it shou
As I understand it, any piece of equipment which can be worn (armor/weapons/trinkets) and is not purchased from a shopkeeper qualifies as something which can be stolen. Thus, you can purchase intelligence or charisma items from a shopkeeper to bolster those attributes, but be sure to wear non-bought items before you log out.
Author:  Tragonis [ Thu Feb 23, 2017 4:17 pm ]
Post subject:  Re: Please review the dehoarding code. Stealing gear it shou
That a bit deceiving, since you can buy limited items from a shopkeeper. And even limitless items can be stolen I they are of qualifying quality and greater number then authorized. Which is a great pain for necromancers, who need to hold enough weapons for controls.
Author:  Dulrik [ Fri Feb 24, 2017 8:26 am ]
Post subject:  Re: Please review the dehoarding code. Stealing gear it shou
Don't forget, if you are buying something from a shopkeeper which might be stolen by logout thieves, the shopkeeper will ask you to confirm the purchase. That's been true for over 4 years now, but it may still be unfamiliar to some people.
Page 1 of 1 All times are UTC - 8 hours
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
http://www.phpbb.com/