Shattered Kingdoms

When shall this be fixed?

I'm pretty sure this bug falls into the "not a critical so we'll get to it when we get it" area man. Learn to live with it.

heh, yeah but I play SK 10 months now, and it's still htere, eeeeeevery time...

As if failing to brew or scribe wasn't enough...

It's been there for 9 years. It's not something that can be fixed by just updating a string. The system as it was written was not intended to have yourself being the subject of such strings. Basically every message in the entire game would have to be rewritten and code support added, all just to fix a grammar bug. I'd like to fix it someday, but it seems there is always going to be more important tasks.

Honestly, no offense to the coders, stuff like this is all throughout the mud. Live with it. To me, I'd rather live with a few grammar errors in SK than have loose things like more classes/races/fixes/updates.

sleeper

I see... True, it is really doing bad to the image of the mud. Yet, I suspected that it was the case Dulrik mentioned, and as far as I understand, it must be a pain to change this one...

If had problems with that one... then check this out.

I'd be complaining more about the fact that the damage roll missed him, but the special effect role suceeded.

As Dulrik mentioned, the weird part of this is that you're casting acid blast on yourself (brew failed, whatever), which the message-generator was never really meant to try and handle. The best effort on this would be to dumb-down the message so that it is less personalised and thus more applicable to both self and foreign targets.



This one, however is more fixable, since it's a normal message - use BUG to report this, since it does require Dulrik to fix; us lesser immortals are unable to mess with damage messages.

Going to get a tad technical here. Having seen a ROM code from the inside, not saying that SK has a normal code but the concept is usable. I'm going to be assuming some things resemble those used in stock ROM codes.

Whenever there is a message to be printed to specific targets the act function is used. The function uses string identifiers $n $N for person doing action and target affected by action, it uses tons of other identifiers handled in the function but that's another issue. Now, I am assuming that the acid blast spell is much like any normal spell nested in magic.c and once its calculated damage is done and checks are made if the enemy is dead and so on and so forth there is a call to act in, possibly, the following manner :



$n resolves to the caster and $N to the target, causing that message since ch and vch are one and the same. The flag TO_CHAR states that the caster gets the message.

Now there is another message that gets printed to the target, pressumably:



Here $n is the caster and the flag TO_VICT states that the victim gets the message.

I realise that there might be some extra work involved tuning all spells and stuff but, can't there be some sort of check saying:



Therefore printing the message to the character ONLY if the target is someone else and using the TO_VICT message to print the correct message to the target. In this case the act function needs to be tuned to check if $n and $N are the same person and return your in the or return the $n name appended with a nice 's at the end and all?


Did that make any sort of sense?

PS: Yes I didn't get into the TO_NOTVICT flag but that's a similar issue anyway