Shattered Kingdoms

Acc > all, except when speed can get you another attack that you can't otherwise get. That has long been accepted. However, since haste and speed don't stack, haste can give you that attack that you can't otherwise get.

It's like you didn't even read what I said. I clearly suggested a % nerf to melee damage to account for the buff that speed stacking with haste would provide. The entire point is to provide a meaningful choice without increasing melee damage too much.

This is necessary for speed to be even a remotely interesting enchantment. Speed vs accuracy is currently not "what is the best enchantment?" - rather it's purely a choice of whether to be a lazy player or not. If you are not willing to put in the work to have a speed and an accuracy weapon, then the optimal choice is an accuracy weapon and one of the many haste potions for any meaningful fight. If you are willing to put in the work, currently you can have the best of both worlds. If speed stacks with haste, then you genuinely have a choice to make.

I don't see how reducing all melee damage across the board would have any effect on the relative strength of speed enchants versus the others. If speed stacked with haste without nerfing stacked speed otherwise, then speed would almost -always- be the best enchantment. The fact that it doesn't means that when you find the best weapon for yourself as a merc, for example, you are forced to choose between accuracy and speed based on whether you want to rely on haste for the extra attack or not. There's only one Coldsnap, you can't carry around one with speed and another with accuracy.

Your argument only makes sense if haste will always outshine speed enchants: And it won't. A weapon with even moderate innate speed can be enchanted with more speed beyond what even GM haste can provide.

I've reworked the code to better account for the mixing of speed-bonus and speed-penalty affects.

The basic rules don't change, they should just be less buggy:
- Haste and speed-enchant will not stack (most powerful will apply)
- Fury/specialize continue to stack with either haste or speed-enchant
- Song of war and dwarf axe bonus stack with everything
- Penalties from song of sleep, slow and certain religious spell all stack
- Haste and slow castings cancel each other out so will never stack
- Speed-enchant and slow can co-exist (speed lessens the slow penalty)

This will be in the next update.

You didn't address innate speed explicitly, but since you say enchant-speed I assume that innate-speed will stack with haste?

Should swap enchant weapon speed with consecrate weapon damage, then, since if these are the confirmed intended ruleset, sorcerers have no reason to ever enchant speed.

The weapon speed is a property of the weapon and not a modifier. All modifiers are applied to the base weapon speed.

Not sure we are on the same page. I am referring to innate speed enchantments builders add to weapons, not to the base weapon speed.

Similar to how innate willpower stacks with enchanted willpower, I would expect innate speed to stack with haste under the ruleset you outlined above. Will it?

I see what you mean, but currently no. All weapon speed enhancements whether innate or player enchanted are lumped together. The total either beats haste and applies or haste beats it and it does not apply.

Just to be clear, the changes here can be summed up as follows:
A) barbarians got a buff in that speed enchants now stack with fury whereas before they didn't,
B) everything else is just less buggy.

You would say this is accurate? If this is the case, I definitely am a fan.

Yes, my summary is confirming the existing expectations. At least, I believe that is how people thought it should be working and I did not deliberately change those rules.

But according to all my tests, haste was already stacking with fury. So if you still have some edge case where it is not, I was not able to repro and it may not be fixed.

I'm not sure what might have caused the edge case before. I just know the following.

All of this was under the effects of Lathron's (GM?) fury.
With weak haste, I got 5 attacks with an unenchanted gladius.
With weak haste, I only got 4 attacks with a gladius with +2 speed.
With weak haste, I only got 4 attacks with a gladius with +3 speed.

With GM haste, I got 5 attacks with all three.

I don't recall what the weak haste was, it might have been a quicksilver potion from the deeps. Perhaps it was so weak that it was only the equivalent of +2 speed, therefore the speed enchants were counting instead of the haste, but since the speed enchants didn't stack with haste, it ended up cancelling out the effects of haste.

I would guess that now if both haste and speed enchants stack with fury, the bug would be fixed. Haven't tested it though from my end.